Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR standardizes the app’s rounded-corner styling by introducing a shared shape palette based on G2/continuous curvature, and updates UI components to use those shapes. It also updates dependency management to include the required library and adjusts .gitignore.
Changes:
- Added
AppShapeshape tokens backed bycapsule’sContinuousRoundedRectangle. - Replaced various
RoundedCornerShape/CornerSizeusages across screens/components withAppShapetokens. - Added the
capsuledependency via version catalog and updated.gitignore.
Reviewed changes
Copilot reviewed 21 out of 22 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| manager/src/main/java/frb/axeron/manager/ui/theme/AppShape.kt | Introduces centralized continuous-rounded shape tokens. |
| manager/src/main/java/frb/axeron/manager/ui/screen/plugin/PluginItem.kt | Applies AppShape to plugin item card shape/clipping. |
| manager/src/main/java/frb/axeron/manager/ui/screen/plugin/Plugin.kt | Updates segmented button shapes to use AppShape. |
| manager/src/main/java/frb/axeron/manager/ui/screen/SettingsEditor.kt | Uses AppShape for pill tabs/cards and text field shapes. |
| manager/src/main/java/frb/axeron/manager/ui/screen/Settings.kt | Updates input field shape to AppShape. |
| manager/src/main/java/frb/axeron/manager/ui/screen/QuickShell.kt | Updates elevated card shape to AppShape. |
| manager/src/main/java/frb/axeron/manager/ui/screen/Home.kt | Applies AppShape across multiple cards. |
| manager/src/main/java/frb/axeron/manager/ui/screen/Flash.kt | Applies AppShape to dialog card. |
| manager/src/main/java/frb/axeron/manager/ui/screen/Activate.kt | Applies AppShape to several cards. |
| manager/src/main/java/frb/axeron/manager/ui/component/SettingsItem.kt | Updates settings item/card and checkbox row shapes. |
| manager/src/main/java/frb/axeron/manager/ui/component/SearchBar.kt | Updates search field shape. |
| manager/src/main/java/frb/axeron/manager/ui/component/PowerDialog.kt | Updates background shape to continuous-rounded. |
| manager/src/main/java/frb/axeron/manager/ui/component/PaletteDialog.kt | Uses AppShape for swatch clip/border. |
| manager/src/main/java/frb/axeron/manager/ui/component/MaterialDialog.kt | Updates dialog and bottom sheet shapes to AppShape. |
| manager/src/main/java/frb/axeron/manager/ui/component/ExtraLabel.kt | Updates label card shapes to AppShape. |
| manager/src/main/java/frb/axeron/manager/ui/component/Dialog.kt | Updates loading dialog surface shape. |
| manager/src/main/java/frb/axeron/manager/ui/component/Card.kt | Applies AppShape to shared card components. |
| manager/src/main/java/frb/axeron/manager/ui/RequestPermissionActivity.kt | Updates bottom sheet and button/icon shapes. |
| manager/src/main/java/frb/axeron/manager/ui/AxActivity.kt | Updates navigation container top corners to AppShape. |
| manager/build.gradle.kts | Adds capsule dependency to the manager module. |
| gradle/libs.versions.toml | Adds version-catalog entry for capsule. |
| .gitignore | Updates ignore list (currently includes duplicates). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
|
|
||
| // aaaa No newline at end of file | ||
| // aaaa |
There was a problem hiding this comment.
Stray placeholder comment (// aaaa) at the end of the file doesn’t add useful context and should be removed to keep the source clean.
Author
|
Added a change: improved the Chinese translations of some technical terms. |
Author
|
I have merged the 4 commits into 1. |
Author
|
@fahrez182 bro,merge it,thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change all rounded corners to G2 curvature to make them more attractive, natural, and modern.
Also optimized the .gitignore configuration.